Paging doesn't work for me - static variables missing

[walt]

These variables are missing in active_record.php and I got an error when paging was set in find_all:

public static $rows_per_page;
public static $page;
public static $pages;
public static $offset;

[Alderete]

I could not get paging to work either, using r197. I tried adding the declarations of static variables which you describe, and that was not enough.

I did in the end get paging to work for me, but ended up having to re-write the two HTML-emitting methods, and fixing a couple defects in find_all(). I described the required changes in the forums, in a post titled  How do you implement paging. The description of the fixes is the last post, after the questions.

[Walt]

Another interesting wrinkle is that when you provide a $limit argument to find_all(), the result is that two calls are made to query() - one with, and one without, the LIMIT keyword in the SQL.

Actually it isn't clear to me that there is a large benefit to doing paging in ActiveRecord? since the DBMS needs to find all the rows anyway, and paging consists of selecting some subset to actually read into memory.